kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gregory Haskins <gregory.haskins@gmail.com>
Cc: avi@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 0/3] qemu-kvm: vhost net support
Date: Thu, 13 Aug 2009 14:53:38 +0300	[thread overview]
Message-ID: <20090813115337.GA4853@redhat.com> (raw)
In-Reply-To: <4A83FA98.1010708@gmail.com>

On Thu, Aug 13, 2009 at 07:35:52AM -0400, Gregory Haskins wrote:
> Michael S. Tsirkin wrote:
> > On Wed, Aug 12, 2009 at 04:27:44PM -0400, Gregory Haskins wrote:
> >> Michael S. Tsirkin wrote:
> >>> This adds support for vhost-net virtio kernel backend.
> >>>
> >>> This is RFC, but works without issues for me.
> >>>
> >>> Still needs to be split up, tested and benchmarked properly,
> >>> but posting it here in case people want to test drive
> >>> the kernel bits I posted.
> >> This has a large degree of rejects against qemu-kvm.git/master.  What
> >> tree does this apply to?
> >>
> >> -Greg
> >>
> > 
> > Likely that tree has advanced since.
> > This is on top of commit b6bbd41fac4b6fb0efc65e083d2151ce1521f615.
> > 
> 
> 
> Hmm....better, but I still get rejects.  Of particular concern is this
> one in net.c:
> 
> @@ -1903,7 +1903,7 @@ static TAPState *net_tap_init(VLANState *vlan,
> const char *model,
>  typedef struct RAWState {
>      VLANClientState *vc;
>      int fd;
> -    uint8_t buf[4096];
> +    uint8_t buf[65000];
>      int promisc;
>  } RAWState;
> 
> 
> I do not see any occurrence of "RAWState" in b6bbd41f (or master, for
> that matter).  There is probably an operator error somewhere in here ;),

Yes. Mine :)

> but any help getting this working is appreciated.

I reposted a clean one which is against latest bits earlier today.
Look for PATCHv2 in your inbox.

> Do you have a git tree I can pull somewhere?
> Kind Regards,
> -Greg
> 

Thanks for the patience,

-- 
MST

      reply	other threads:[~2009-08-13 11:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-10 19:23 [PATCH 0/3] qemu-kvm: vhost net support Michael S. Tsirkin
2009-08-10 20:51 ` Anthony Liguori
2009-08-12 17:35   ` Michael S. Tsirkin
2009-08-19  8:11     ` Or Gerlitz
2009-08-20  7:19     ` Rusty Russell
2009-08-20 13:41       ` Michael S. Tsirkin
2009-08-20 17:00       ` Michael S. Tsirkin
2009-08-20 17:24         ` Avi Kivity
2009-08-20 17:49           ` Michael S. Tsirkin
2009-08-12 20:27 ` Gregory Haskins
2009-08-13  5:59   ` Michael S. Tsirkin
2009-08-13 11:35     ` Gregory Haskins
2009-08-13 11:53       ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090813115337.GA4853@redhat.com \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=gregory.haskins@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).