From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 0/3] qemu-kvm: vhost net support
Date: Thu, 13 Aug 2009 14:53:38 +0300
Message-ID: <20090813115337.GA4853@redhat.com>
References: <20090810192304.GA16781@redhat.com> <4A8325C0.7060001@gmail.com> <20090813055941.GB3029@redhat.com> <4A83FA98.1010708@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: avi@redhat.com, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
To: Gregory Haskins <gregory.haskins@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:52957 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753908AbZHMLza (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 13 Aug 2009 07:55:30 -0400
Content-Disposition: inline
In-Reply-To: <4A83FA98.1010708@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Aug 13, 2009 at 07:35:52AM -0400, Gregory Haskins wrote:
> Michael S. Tsirkin wrote:
> > On Wed, Aug 12, 2009 at 04:27:44PM -0400, Gregory Haskins wrote:
> >> Michael S. Tsirkin wrote:
> >>> This adds support for vhost-net virtio kernel backend.
> >>>
> >>> This is RFC, but works without issues for me.
> >>>
> >>> Still needs to be split up, tested and benchmarked properly,
> >>> but posting it here in case people want to test drive
> >>> the kernel bits I posted.
> >> This has a large degree of rejects against qemu-kvm.git/master.  What
> >> tree does this apply to?
> >>
> >> -Greg
> >>
> > 
> > Likely that tree has advanced since.
> > This is on top of commit b6bbd41fac4b6fb0efc65e083d2151ce1521f615.
> > 
> 
> 
> Hmm....better, but I still get rejects.  Of particular concern is this
> one in net.c:
> 
> @@ -1903,7 +1903,7 @@ static TAPState *net_tap_init(VLANState *vlan,
> const char *model,
>  typedef struct RAWState {
>      VLANClientState *vc;
>      int fd;
> -    uint8_t buf[4096];
> +    uint8_t buf[65000];
>      int promisc;
>  } RAWState;
> 
> 
> I do not see any occurrence of "RAWState" in b6bbd41f (or master, for
> that matter).  There is probably an operator error somewhere in here ;),

Yes. Mine :)

> but any help getting this working is appreciated.

I reposted a clean one which is against latest bits earlier today.
Look for PATCHv2 in your inbox.

> Do you have a git tree I can pull somewhere?
> Kind Regards,
> -Greg
> 

Thanks for the patience,

-- 
MST