From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH -tip v14 01/12] x86: instruction decoder API Date: Thu, 20 Aug 2009 16:46:10 +0200 Message-ID: <20090820144608.GC6389@nowhere> References: <20090813203403.31965.20973.stgit@localhost.localdomain> <20090813203413.31965.49709.stgit@localhost.localdomain> <20090819234227.GJ4972@nowhere> <4A8D60BD.8010100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ingo Molnar , Steven Rostedt , lkml , systemtap , kvm , DLE , Jim Keniston , "H. Peter Anvin" , Ananth N Mavinakayanahalli , Avi Kivity , Andi Kleen , Christoph Hellwig , "Frank Ch. Eigler" , Jason Baron , "K.Prasad" , Lai Jiangshan , Li Zefan , =?utf-8?B?UHJ6ZW15c8WCYXdQYXdlxYJjenlr?= , Roland McGrath , Sam Ravnborg , Srikar Dronamraju , Tom Zanussi , Vegard Nossum To: Masami Hiramatsu Return-path: Received: from mail-ew0-f207.google.com ([209.85.219.207]:47968 "EHLO mail-ew0-f207.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbZHTOqO (ORCPT ); Thu, 20 Aug 2009 10:46:14 -0400 Content-Disposition: inline In-Reply-To: <4A8D60BD.8010100@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Aug 20, 2009 at 10:42:05AM -0400, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: >> On Thu, Aug 13, 2009 at 04:34:13PM -0400, Masami Hiramatsu wrote: >>> Add x86 instruction decoder to arch-specific libraries. This decode= r >>> can decode x86 instructions used in kernel into prefix, opcode, mod= rm, >>> sib, displacement and immediates. This can also show the length of >>> instructions. >>> >>> This version introduces instruction attributes for decoding instruc= tions. >>> The instruction attribute tables are generated from the opcode map = file >>> (x86-opcode-map.txt) by the generator script(gen-insn-attr-x86.awk)= =2E >>> >>> Currently, the opcode maps are based on opcode maps in Intel(R) 64 = and >>> IA-32 Architectures Software Developers Manual Vol.2: Appendix.A, >>> and consist of below two types of opcode tables. >>> >>> 1-byte/2-bytes/3-bytes opcodes, which has 256 elements, are >>> written as below; >>> >>> Table: table-name >>> Referrer: escaped-name >>> opcode: mnemonic|GrpXXX [operand1[,operand2...]] [(extra1)[,(extr= a2)...] [| 2nd-mnemonic ...] >>> (or) >>> opcode: escape # escaped-name >>> EndTable >>> >>> Group opcodes, which has 8 elements, are written as below; >>> >>> GrpTable: GrpXXX >>> reg: mnemonic [operand1[,operand2...]] [(extra1)[,(extra2)...] [= | 2nd-mnemonic ...] >>> EndTable >>> >>> These opcode maps include a few SSE and FP opcodes (for setup), bec= ause >>> those opcodes are used in the kernel. >>> >> >> >> I'm getting the following build error on an old K7 box: >> >> arch/x86/lib/inat.c: In function =E2=80=98inat_get_opcode_attribute=E2= =80=99: >> arch/x86/lib/inat.c:29: erreur: =E2=80=98inat_primary_table=E2=80=99= undeclared (first use in this function) >> arch/x86/lib/inat.c:29: erreur: (Each undeclared identifier is repor= ted only once >> arch/x86/lib/inat.c:29: erreur: for each function it appears in.) > > Thanks for reporting! > Hmm, it seems that inat-tables.c is not correctly generated. > Could you tell me which awk you used and send the inat-tables.c? > > Thank you, > Sure: $ awk -Wv mawk 1.3.3 Nov 1996, Copyright (C) Michael D. Brennan compiled limits: max NF 32767 sprintf buffer 2040 And I've sent you the content of inat_tables.c in the other answer :)