From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH][RFC] Use return value from kvm_set_irq() to re-inject PIT interrupts.
Date: Mon, 24 Aug 2009 22:01:50 +0300 [thread overview]
Message-ID: <20090824190150.GC11762@redhat.com> (raw)
In-Reply-To: <20090824181905.GB11762@redhat.com>
On Mon, Aug 24, 2009 at 09:19:05PM +0300, Gleb Natapov wrote:
> > > It is obviously wrong thing to do from assigned devices POV.
> >
> > Thats not entirely clear to me. So what happens if a guest with PIC
> > assigned device resets with a pending IRR? The host interrupt line will
> > be kept disabled, even though the guest is able to process further
> > interrupts?
> The host interrupt line will be enabled (assigned device ack notifier
> does this) without clearing interrupt condition in assigned device
> (guest hasn't acked irq so how can we be sure it ran device's irq
> handler?). Host will hang.
>
Actually, on the second thought, it will not hang. Next time host
interrupt handler runs it will disable interrupt once again.
--
Gleb.
next prev parent reply other threads:[~2009-08-24 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 12:06 [PATCH][RFC] Use return value from kvm_set_irq() to re-inject PIT interrupts Gleb Natapov
2009-08-24 16:32 ` Marcelo Tosatti
2009-08-24 17:16 ` Gleb Natapov
2009-08-24 17:44 ` Marcelo Tosatti
2009-08-24 18:19 ` Gleb Natapov
2009-08-24 19:01 ` Gleb Natapov [this message]
2009-08-26 12:45 ` Marcelo Tosatti
2009-08-26 12:43 ` Marcelo Tosatti
2009-08-26 13:19 ` Gleb Natapov
2009-08-26 13:38 ` Marcelo Tosatti
2009-08-26 13:48 ` Avi Kivity
2009-08-26 13:50 ` Gleb Natapov
2009-08-26 13:49 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824190150.GC11762@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).