Re: [patch 2/5] KVM: reintroduce guest mode bit and unify remote request code

Avi Kivity
2009-08-27T08:15:24Z

On 08/27/2009 04:20 AM, Marcelo Tosatti wrote:
> Split KVM_REQ_KICKED in two bits: KVM_VCPU_KICKED, to indicate
> whether a vcpu has been IPI'ed, and KVM_VCPU_GUEST_MODE, in a separate
> vcpu_state variable.
>
> Unify remote requests with kvm_vcpu_kick.
>
> Synchronous requests wait on KVM_VCPU_GUEST_MODE, via wait_on_bit/wake_up_bit.
>
>

I did miss guest_mode.

> + unsigned long vcpu_state;
>

Why not bool guest_mode? Saves two atomics per exit.

--
error compiling committee.c: too many arguments to function