From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 2/2] Handle emulation failure in userspace Date: Tue, 1 Sep 2009 09:31:33 -0300 Message-ID: <20090901123133.GA19421@amt.cnet> References: <1251470933-14500-1-git-send-email-m.gamal005@gmail.com> <1251470933-14500-2-git-send-email-m.gamal005@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org To: Mohammed Gamal Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55155 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754056AbZIAMcB (ORCPT ); Tue, 1 Sep 2009 08:32:01 -0400 Content-Disposition: inline In-Reply-To: <1251470933-14500-2-git-send-email-m.gamal005@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Aug 28, 2009 at 04:48:53PM +0200, Mohammed Gamal wrote: > Since we return to userspace from KVM on invalid state emulation failure, let > qemu handle it. > > Signed-off-by: Mohammed Gamal > --- > qemu-kvm.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/qemu-kvm.c b/qemu-kvm.c > index b59e403..a1648e0 100644 > --- a/qemu-kvm.c > +++ b/qemu-kvm.c > @@ -1029,6 +1029,14 @@ int kvm_run(kvm_vcpu_context_t vcpu, void *env) > r = kvm_s390_handle_reset(kvm, vcpu, run); > break; > #endif > + case KVM_EXIT_INTERNAL_ERROR: > + kvm_show_regs(vcpu); > + fprintf(stderr, "\nKVM internal error. Suberror: %d\n", > + run->internal.suberror); > + if (run->internal.suberror == KVM_INTERNAL_ERROR_EMULATION) > + fprintf(stderr, "emulation failure, check dmesg for details\n"); > + abort(); > + break; > default: > if (kvm_arch_run(vcpu)) { > fprintf(stderr, "unhandled vm exit: 0x%x\n", run->exit_reason); > -- > 1.6.0.4 The common practice is to print msg first and then kvm_show_regs? Applied the kvm.h update, thanks.