From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCHv3] VMX: Enhance invalid guest state emulation
Date: Tue, 1 Sep 2009 12:55:15 -0300
Message-ID: <20090901155515.GA23028@amt.cnet>
References: <1251802098-23819-1-git-send-email-m.gamal005@gmail.com> <20090901114806.GA18778@amt.cnet> <52d4a3890909010514n20ceef87i4767e277c550a581@mail.gmail.com> <20090901121804.GA19145@amt.cnet> <52d4a3890909010608h1f406b42j98d403493859d6b6@mail.gmail.com> <20090901132938.GA19864@amt.cnet> <52d4a3890909010632wd1b6d9fxb2b5f5042e151b4f@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: avi@redhat.com, kvm@vger.kernel.org
To: Mohammed Gamal <m.gamal005@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:14543 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754532AbZIAPzg (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 1 Sep 2009 11:55:36 -0400
Content-Disposition: inline
In-Reply-To: <52d4a3890909010632wd1b6d9fxb2b5f5042e151b4f@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Sep 01, 2009 at 03:32:29PM +0200, Mohammed Gamal wrote:
> > + =A0 =A0 =A0 if (vmx->emulation_required && emulate_invalid_guest_=
state)
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return;
> >
> > And then emulate in the exit handler.
> >
> >> I'd appreciate any suggestions you have to alleviate this.
> >
> > I fail to see why you need an internal loop if you can use the exte=
rnal
> > (__vcpu_run) one.
>=20
> Because it's not just used by VMX. So I don't think it'd be wise to
> use it for something that's VMX-specific.

OK, it can be done incrementally. This is already an improvement.
Applied, thanks.