From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH v2] vmxcap: Add tool to query vmx capabilities Date: Wed, 2 Sep 2009 13:32:19 +0530 Message-ID: <20090902080219.GA8422@amit-x200.redhat.com> References: <1251821885-28967-1-git-send-email-avi@redhat.com> <20090902065013.GA6539@amit-x200.redhat.com> <4A9E249D.7050301@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60254 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbZIBICi (ORCPT ); Wed, 2 Sep 2009 04:02:38 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8282dnA016657 for ; Wed, 2 Sep 2009 04:02:39 -0400 Content-Disposition: inline In-Reply-To: <4A9E249D.7050301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On (Wed) Sep 02 2009 [10:54:05], Avi Kivity wrote: > On 09/02/2009 09:50 AM, Amit Shah wrote: >> On (Tue) Sep 01 2009 [19:18:05], Avi Kivity wrote: >> >>> This should really be in the kernel, but there are too many of them. >>> >>> Signed-off-by: Avi Kivity >>> --- >>> >>> v2: try /dev/cpu/0/msr first >>> >>> kvm/scripts/vmxcap | 154 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> >> Why not call it cpucap and add svm support later? >> > > It's just a hack. In that case there's danger of this becoming a "stable interface" - when eg libvirt picks up support for it. It is useful functionality. Amit