From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] Fix coalesced interrupt reporting in IOAPIC
Date: Thu, 3 Sep 2009 14:31:17 -0300
Message-ID: <20090903173117.GA10255@amt.cnet>
References: <20090903091034.GB30093@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:51461 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753291AbZICRc4 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 3 Sep 2009 13:32:56 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n83HWwb9024011
	for <kvm@vger.kernel.org>; Thu, 3 Sep 2009 13:32:59 -0400
Content-Disposition: inline
In-Reply-To: <20090903091034.GB30093@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Sep 03, 2009 at 12:10:34PM +0300, Gleb Natapov wrote:
> This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index e9de458..38a2d20 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -194,6 +194,8 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
>  			if ((edge && old_irr != ioapic->irr) ||
>  			    (!edge && !entry.fields.remote_irr))
>  				ret = ioapic_service(ioapic, irq);
> +			else
> +				ret = 0; /* report coalesced interrupt */
>  		}
>  		trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
>  	}
> --
> 			Gleb.

Applied, thanks.