From: Gleb Natapov <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "avi@redhat.com" <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu
Date: Wed, 9 Sep 2009 19:36:52 +0300 [thread overview]
Message-ID: <20090909163652.GK22885@redhat.com> (raw)
In-Reply-To: <4AA7D8B9.4010906@siemens.com>
On Wed, Sep 09, 2009 at 06:32:57PM +0200, Jan Kiszka wrote:
> >>> The patch doesn't touch shared code. (it is almost impossible to tell
> >>> what code is shared and what's not nowadays)
> >> cpu_dump_state() is definitely shared.
> >>
> > Ah this one line. Yes it is. But I have not good commit message for this
> > one liner change for upstream :)
>
> That's why I suggested to post the corresponding change also for
> upstream. Even if it doesn't need it now, it will one day. :)
>
I looked at the code. This changes doesn't make sense for upstream right
now IMHO. I do agree that this one linear should go into upstream. I'll
think about commit message tonight.
--
Gleb.
prev parent reply other threads:[~2009-09-09 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 15:33 [PATCH] call kvm_cpu_synchronize_state() on target vcpu Gleb Natapov
2009-09-09 15:41 ` Avi Kivity
2009-09-09 15:47 ` Jan Kiszka
2009-09-09 15:49 ` Gleb Natapov
2009-09-09 15:57 ` Jan Kiszka
2009-09-09 16:07 ` Gleb Natapov
2009-09-09 16:21 ` Jan Kiszka
2009-09-09 16:27 ` Gleb Natapov
2009-09-09 16:32 ` Jan Kiszka
2009-09-09 16:36 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909163652.GK22885@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).