From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] qemu-kvm: Fix guest single-stepping Date: Fri, 18 Sep 2009 13:05:25 -0300 Message-ID: <20090918160524.GA3888@amt.cnet> References: <4AB277B5.5000105@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm-devel To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753788AbZIRQSu (ORCPT ); Fri, 18 Sep 2009 12:18:50 -0400 Content-Disposition: inline In-Reply-To: <4AB277B5.5000105@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Applied, thanks. On Thu, Sep 17, 2009 at 07:53:57PM +0200, Jan Kiszka wrote: > Hopefully the last regression of 4c0960c0: KVM_SET_GUEST_DEBUG requires > properly synchronized guest registers (on x86: eflags) on entry. > > Signed-off-by: Jan Kiszka > --- > > qemu-kvm.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/qemu-kvm.c b/qemu-kvm.c > index 78eeb6f..569397e 100644 > --- a/qemu-kvm.c > +++ b/qemu-kvm.c > @@ -2282,6 +2282,10 @@ static void kvm_invoke_set_guest_debug(void *data) > { > struct kvm_set_guest_debug_data *dbg_data = data; > > + if (cpu_single_env->kvm_cpu_state.regs_modified) { > + kvm_arch_put_registers(cpu_single_env); > + cpu_single_env->kvm_cpu_state.regs_modified = 0; > + } > dbg_data->err = > kvm_set_guest_debug(cpu_single_env->kvm_cpu_state.vcpu_ctx, > &dbg_data->dbg); > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html