From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 04/24] piix4_dev is not used for pc's
Date: Fri, 18 Sep 2009 16:05:41 -0300
Message-ID: <20090918190541.GB14562@amt.cnet>
References: <cover.1253272938.git.quintela@redhat.com> <e01c2c9621a1e3fd90b4eb0654b6619eec76c2c4.1253272938.git.quintela@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Juan Quintela <quintela@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:1026 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753353AbZIRT5q (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 18 Sep 2009 15:57:46 -0400
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8IJvoHg023596
	for <kvm@vger.kernel.org>; Fri, 18 Sep 2009 15:57:50 -0400
Content-Disposition: inline
In-Reply-To: <e01c2c9621a1e3fd90b4eb0654b6619eec76c2c4.1253272938.git.quintela@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Sep 18, 2009 at 01:41:13PM +0200, Juan Quintela wrote:
> And mips still don't have pci assignment support :)
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  Makefile.target |    2 +-
>  hw/piix_pci.c   |    3 ---
>  2 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index 5fad812..58f8b9e 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -209,9 +209,9 @@ obj-i386-y += cirrus_vga.o apic.o ioapic.o parallel.o acpi.o piix_pci.o
>  obj-i386-y += usb-uhci.o vmmouse.o vmport.o vmware_vga.o hpet.o
>  obj-i386-y += device-hotplug.o pci-hotplug.o smbios.o wdt_ib700.o
>  obj-i386-y += extboot.o
> -obj-i386-y += piix4.o
>  obj-i386-y += ne2000-isa.o
>  obj-i386-y += testdev.o
> +
>  ifeq ($(USE_KVM_PIT), 1)
>  obj-i386-y += i8254-kvm.o
>  endif
> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> index 26e00db..d177e97 100644
> --- a/hw/piix_pci.c
> +++ b/hw/piix_pci.c
> @@ -291,9 +291,6 @@ int piix_get_irq(int pin)
>  {
>      if (piix3_dev)
>          return piix3_dev->dev.config[0x60+pin];
> -    if (piix4_dev)
> -        return piix4_dev->config[0x60+pin];
> -
>      return 0;
>  }

Not applying because its dead code with the current state of pc.c
configuration but this prevents one to use piix4.