From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 00/24] configure and Makefile cleanup Date: Fri, 18 Sep 2009 16:57:14 -0300 Message-ID: <20090918195714.GC16767@amt.cnet> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Juan Quintela Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22622 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752291AbZIRT5q (ORCPT ); Fri, 18 Sep 2009 15:57:46 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8IJvoBc019281 for ; Fri, 18 Sep 2009 15:57:50 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Sep 18, 2009 at 01:41:08PM +0200, Juan Quintela wrote: > This series: > - werror is not disabled unconditoanally, you can disable it with > --disable-werror. > - clean configure and Makefile* of mis-merges > - sync such files to qemu upstream > - kvm options are detected and configured _after_ detecting kvm, not > the other way around > - add command line options and change styse so kvm-cap-pit and > kvm-cap-device-assignment looks like the other options. Bring command > line flags to enable/disable them, and fix code to compile. > - CONFIG_CPU_EMULATION is back, and it works (it is still a hack, proper > fix means moving code to new files and other conditional compilation, better > to do it at qemu upstream. > - Why do we define "-D__user=" for gcc? Nothing uses it (/me guess sparse > missmerge) > > What I didn't touch: > - kvm-kmod. > - CFLAGS += $(KVM_CFLAGS) > on Makefile.target, only 4-5 files need them. Didn't investigate too much > into it. > - I only tested it on x86_64, i386 should work. powerpc/ia64 -> dunno. > > For upstream: > - kvm_cflags reorganization: make sense > - KVM_CAP_PIT: haven't looked how much support is missing there > - DEVICE_ASSIGNMENT: idem > - CONFIG_CPU_EMULATION: Proper implementation is not trivial. What is in > qemu-kvm is a hack, proper integration requires moving code back and forth. > Not sure how important is to have this option. > > Comments? Juan, Thanks for doing this. I've applied all patches except those replied to.