From: Rusty Russell <rusty@rustcorp.com.au>
To: virtualization@lists.linux-foundation.org
Cc: Anthony Liguori <anthony@codemonkey.ws>,
Amit Shah <amit.shah@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: Extending virtio_console to support multiple ports
Date: Mon, 21 Sep 2009 14:50:45 +0930 [thread overview]
Message-ID: <200909211450.47348.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A9BFC31.9070005@codemonkey.ws>
On Tue, 1 Sep 2009 02:07:05 am Anthony Liguori wrote:
> Amit Shah wrote:
> Functionally speaking, both virtio-console and virtio-serial do the same
> thing. In fact, virtio-console is just a subset of virtio-serial.
>
> If there are problems converging the two drivers in Linux, then I
> suggest you have two separate driver modules in Linux. That would
> obviously be rejected for Linux though because you cannot have two
> drivers for the same device. Why should qemu have a different policy?
I've been on leave, cheerfully not thinking about this.
AFAICT, a console and serial are very similar, so it makes sense to merge
them. But a serial port doesn't have framing either; if it does, it's
something else.
And generally using virtio framing in upper layers is a mistake (one we've
made in the qemu implementations, but that's unfortunate).
Thanks,
Rusty.
prev parent reply other threads:[~2009-09-21 5:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 6:17 Extending virtio_console to support multiple ports Amit Shah
2009-08-25 6:17 ` [PATCH] virtio_console: Add interface for guest and host communication Amit Shah
2009-08-25 6:17 ` [PATCH 1/3] char: Emit 'CLOSED' events on char device close Amit Shah
2009-08-25 6:17 ` [PATCH 2/3] virtio-console: rename dvq to ovq Amit Shah
2009-08-25 8:16 ` [PATCH 3/3] virtio-console: Add interface for generic guest-host communication Amit Shah
2009-08-26 11:27 ` Extending virtio_console to support multiple ports Amit Shah
2009-08-26 15:45 ` Amit Shah
2009-08-27 4:07 ` Benjamin Herrenschmidt
2009-08-27 6:51 ` [Qemu-devel] " Amit Shah
2009-08-27 9:08 ` Alan Cox
2009-08-27 9:27 ` Benjamin Herrenschmidt
2009-08-27 11:45 ` [PATCH] hvc_console: provide (un)locked version for hvc_resize() Hendrik Brueckner
2009-08-29 1:15 ` [Qemu-devel] Re: Extending virtio_console to support multiple ports Jamie Lokier
2009-08-27 5:04 ` Michael Ellerman
2009-08-27 6:52 ` Amit Shah
2009-08-27 14:13 ` Ryan Arnold
2009-08-28 17:00 ` Anthony Liguori
2009-08-30 10:10 ` Amit Shah
2009-08-30 12:48 ` Anthony Liguori
2009-08-30 13:17 ` Amit Shah
2009-08-31 13:17 ` Anthony Liguori
2009-08-31 13:51 ` Amit Shah
2009-08-31 14:21 ` Anthony Liguori
2009-08-31 14:31 ` Amit Shah
2009-08-31 15:56 ` Anthony Liguori
2009-08-31 16:19 ` Amit Shah
2009-08-31 16:37 ` Anthony Liguori
2009-09-21 5:20 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909211450.47348.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox