From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] qemu-kvm: kvm headers update Date: Tue, 6 Oct 2009 19:18:31 +0200 Message-ID: <20091006171831.GA3737@redhat.com> References: <20091005094612.GA30068@redhat.com> <4ACA12FB.7030805@redhat.com> <20091005192720.GA3399@redhat.com> <4ACB1358.3000807@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932250AbZJFRU7 (ORCPT ); Tue, 6 Oct 2009 13:20:59 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n96HKXBs006572 for ; Tue, 6 Oct 2009 13:20:33 -0400 Content-Disposition: inline In-Reply-To: <4ACB1358.3000807@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 06, 2009 at 11:52:24AM +0200, Avi Kivity wrote: > On 10/05/2009 09:27 PM, Michael S. Tsirkin wrote: >> >> >>> Or is this the output of 'make headers_install'? >>> >> yes. I just added include to kvm_types to add the CONFIG_ stuff. >> Or maybe instead we should fix users to depend on the correct ifdefs. >> >> > > I think 'make headers_install' results in non-portable headers since it > unifdefs stuff out. Heh, take a look at the diff, if you see issues, let me know. > -- > error compiling committee.c: too many arguments to function