From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/3] qemu-kvm: fix build with KVM_CAP_SET_GUEST_DEBUG Date: Wed, 7 Oct 2009 14:18:31 +0200 Message-ID: <20091007121831.GB31484@redhat.com> References: <20091007111917.GB20835@redhat.com> <4ACC86A0.9080309@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: avi@redhat.com, kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5566 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759018AbZJGMVB (ORCPT ); Wed, 7 Oct 2009 08:21:01 -0400 Content-Disposition: inline In-Reply-To: <4ACC86A0.9080309@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 07, 2009 at 02:16:32PM +0200, Jan Kiszka wrote: > Michael S. Tsirkin wrote: > > Fix build with KVM_CAP_SET_GUEST_DEBUG: use QLIST macro > > to declare list head. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > qemu-kvm.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/qemu-kvm.h b/qemu-kvm.h > > index 4523e25..d6748c7 100644 > > --- a/qemu-kvm.h > > +++ b/qemu-kvm.h > > @@ -1229,7 +1229,7 @@ typedef struct KVMState { > > int broken_set_mem_region; > > int migration_log; > > #ifdef KVM_CAP_SET_GUEST_DEBUG > > - struct kvm_sw_breakpoint_head kvm_sw_breakpoints; > > + QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints; > > #endif > > struct kvm_context kvm_context; > > } KVMState; > > If it's required here I bet we need this upstream too, right? No, upstream does not have qemu-kvm.h All these files are qemu-kvm only. upstream builds fine as is. > Then > please also file a corresponding patch for qemu. > > Thanks, > Jan > > -- > Siemens AG, Corporate Technology, CT SE 2 > Corporate Competence Center Embedded Linux