From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-commits] [COMMIT c0b1905] qemu/pci: reset device registers on bus reset Date: Wed, 7 Oct 2009 22:07:35 +0200 Message-ID: <20091007200735.GA4085@redhat.com> References: <200910051452.n95EphXY002170@d03av01.boulder.ibm.com> <4ACC4F43.1010906@redhat.com> <20091007195338.GA3923@redhat.com> <4ACCF38F.4040309@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37093 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754275AbZJGUKH (ORCPT ); Wed, 7 Oct 2009 16:10:07 -0400 Content-Disposition: inline In-Reply-To: <4ACCF38F.4040309@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 07, 2009 at 10:01:19PM +0200, Avi Kivity wrote: > On 10/07/2009 09:53 PM, Michael S. Tsirkin wrote: >> On Wed, Oct 07, 2009 at 10:20:19AM +0200, Avi Kivity wrote: >> >>> On 10/05/2009 04:53 PM, Anthony Liguori wrote: >>> >>>> From: Michael S. Tsirkin >>>> >>>> Reset BARs and a couple of other registers on bus reset, as per PCI >>>> spec. >>>> >>>> >>> This commit breaks Windows XP restart. After a restart Windows switches >>> from 800x600 cirrus logic vga to 640x480 standard vga. My guess is that >>> this is due to two mutually-cancelling bugs: >>> >> Could you please tell me how to reproduce the problem exactly? >> I tried several configurations but in all of them windows >> seems to keep 800x600 across restarts, and shows display adapter >> as cirrus vga. >> > > Clean Windows XP install (-smp 2), boot, reboot. > > After restart it also loses S3 (so Standby is gr[ae]yed out in the > shutdown menu). OK, see it now, finally. I'll work on it. > -- > Do not meddle in the internals of kernels, for they are subtle and quick to panic.