From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 3/3] qemu: cleanup unused macros in cirrus
Date: Thu, 8 Oct 2009 18:07:41 +0200
Message-ID: <20091008160741.GB13710@redhat.com>
References: <cover.1255013225.git.mst@redhat.com> <20091008145247.GD12275@redhat.com> <m34oq9kix8.fsf@neno.mitica>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	kvm-devel <kvm@vger.kernel.org>
To: Juan Quintela <quintela@trasno.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:20660 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758646AbZJHQKa (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 8 Oct 2009 12:10:30 -0400
Content-Disposition: inline
In-Reply-To: <m34oq9kix8.fsf@neno.mitica>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Oct 08, 2009 at 05:24:35PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> > Cirrus vga has a copy of many PCI macros,
> > and it doesn't even use them. Clean up.
> > @@ -3248,8 +3213,8 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev)
> >       /* setup PCI */
> >       pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_CIRRUS);
> >       pci_config_set_device_id(pci_conf, device_id);
> > +     //pci_conf[0x04] = PCI_COMMAND_IOACCESS | PCI_COMMAND_MEMACCESS;
> 
> If it is wrong as you claim in the other patch, just remove it, or at
> least put a comment.

Of course. sorry.

> >       pci_config_set_class(pci_conf, PCI_CLASS_DISPLAY_VGA);
> > -     pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL;
> 
> Did yo;u wanted to remove this one also?

Yes, this is the default anyway.

> >  
> >       /* setup memory space */
> >       /* memory #0 LFB */
> 
> Nice cleanup for the rest :)
> 
> Later, Juan.