From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 1/9] KVM: SVM: Notify nested hypervisor of lost event injections Date: Thu, 8 Oct 2009 18:22:22 +0200 Message-ID: <20091008162222.GG14073@amd.com> References: <1254996199-17667-1-git-send-email-joerg.roedel@amd.com> <1254996199-17667-2-git-send-email-joerg.roedel@amd.com> <4ACE0F6C.3060103@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Avi Kivity Return-path: Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:56560 "EHLO TX2EHSOBE005.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758727AbZJHQXL (ORCPT ); Thu, 8 Oct 2009 12:23:11 -0400 Content-Disposition: inline In-Reply-To: <4ACE0F6C.3060103@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Oct 08, 2009 at 06:12:28PM +0200, Avi Kivity wrote: > On 10/08/2009 12:03 PM, Joerg Roedel wrote: > >From: Alexander Graf > > > >If event_inj is valid on a #vmexit the host CPU would write > >the contents to exit_int_info, so the hypervisor knows that > >the event wasn't injected. > > > >We don't do this in nested SVM by now which is a bug and > >fixed by this patch. > > We need to start thinking about regression tests for these bugs. It > would be relatively easy to set up something with save->cr3 == cr3 > (i.e. no isolation, mmu virtualization, etc.). Should be doable with a in-kernel regression test-suite module, I think. Triggering such (race-condition like) test cases from userspace is somewhat hard. Joerg