From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant Date: Sun, 11 Oct 2009 18:12:32 +0200 Message-ID: <20091011161232.GA10132@redhat.com> References: <4ACE0FC6.3050908@redhat.com> <20091008184011.GA6576@shareable.org> <20091011133626.GA10229@redhat.com> <20091011134559.GN16702@redhat.com> <20091011135240.GA10277@redhat.com> <20091011135748.GO16702@redhat.com> <20091011143535.GA10401@redhat.com> <4AD1EED3.5000901@redhat.com> <20091011144428.GA10429@redhat.com> <4AD1F173.8040401@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gleb Natapov , Jamie Lokier , Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40980 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754738AbZJKQP0 (ORCPT ); Sun, 11 Oct 2009 12:15:26 -0400 Content-Disposition: inline In-Reply-To: <4AD1F173.8040401@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Oct 11, 2009 at 04:53:39PM +0200, Avi Kivity wrote: > On 10/11/2009 04:44 PM, Michael S. Tsirkin wrote: >> On Sun, Oct 11, 2009 at 04:42:27PM +0200, Avi Kivity wrote: >> >>> On 10/11/2009 04:35 PM, Michael S. Tsirkin wrote: >>> >>>> No, this is not how it works, I think. >>>> Currently BIOS ROM is loaded only on init, directly into qemu memory. >>>> >>>> >>> If we change it we break in-place upgrades - install qemu, run guest, >>> upgrade qemu, reboot guest - now the old qemu runs with a new bios which >>> may or may not work. >>> >> Sorry, could not parse this. >> If you upgraded qemu, you are running with new qemu with new bios? >> > > The guest is running during the upgrade, so the qemu executable is still > from the old install (but deleted). Oh, I don't think we should re-read it from file each time. We could read it at startup, keep a copy around for reboots. > -- > error compiling committee.c: too many arguments to function