From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant Date: Sun, 11 Oct 2009 18:39:09 +0200 Message-ID: <20091011163909.GA6261@redhat.com> References: <20091011135240.GA10277@redhat.com> <20091011135748.GO16702@redhat.com> <20091011143535.GA10401@redhat.com> <4AD1EED3.5000901@redhat.com> <20091011144428.GA10429@redhat.com> <4AD1F173.8040401@redhat.com> <20091011161232.GA10132@redhat.com> <4AD206BE.3050904@redhat.com> <20091011163334.GA6248@redhat.com> <4AD209BD.5020300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , "qemu-devel@nongnu.org" , Gleb Natapov , kvm-devel To: Avi Kivity Return-path: Content-Disposition: inline In-Reply-To: <4AD209BD.5020300@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Sun, Oct 11, 2009 at 06:37:17PM +0200, Avi Kivity wrote: > On 10/11/2009 06:33 PM, Michael S. Tsirkin wrote: >> On Sun, Oct 11, 2009 at 06:24:30PM +0200, Avi Kivity wrote: >> >>> On 10/11/2009 06:12 PM, Michael S. Tsirkin wrote: >>> >>>> >>>>> The guest is running during the upgrade, so the qemu executable is still >>>>> from the old install (but deleted). >>>>> >>>>> >>>> Oh, I don't think we should re-read it from file each time. >>>> We could read it at startup, keep a copy around for reboots. >>>> >>>> >>> We do that, see hw/loader.c. >>> >> Which function specifically? >> > > rom_add_file(). Is it used for BIOS? pc.c seems to call this for initrd only? > -- > error compiling committee.c: too many arguments to function