kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, avi@redhat.com, kvm@vger.kernel.org
Subject: Re: Add qemu_send_raw() to vlan.
Date: Thu, 15 Oct 2009 19:46:44 -0300	[thread overview]
Message-ID: <20091015224644.GA17457@amt.cnet> (raw)
In-Reply-To: <20091015073312.GC30889@redhat.com>

On Thu, Oct 15, 2009 at 09:33:12AM +0200, Gleb Natapov wrote:
> On Thu, Oct 15, 2009 at 08:04:45AM +0100, Mark McLoughlin wrote:
> > Hi Gleb,
> > 
> > On Tue, 2009-05-26 at 13:03 +0300, Gleb Natapov wrote:
> > > It gets packet without virtio header and adds it if needed.  Allows to
> > > inject packets to vlan from outside. To send gracious arp for instance.
> > ...
> > > diff --git a/net.h b/net.h
> > > index 931133b..3d0b6f2 100644
> > > --- a/net.h
> > > +++ b/net.h
> > > ...
> > > @@ -63,6 +64,7 @@ int qemu_can_send_packet(VLANClientState *vc);
> > >  ssize_t qemu_sendv_packet(VLANClientState *vc, const struct iovec *iov,
> > >                            int iovcnt);
> > >  int qemu_send_packet(VLANClientState *vc, const uint8_t *buf, int size);
> > > +void qemu_send_packet_raw(VLANClientState *vc, const uint8_t *buf, int size);
> > >  void qemu_format_nic_info_str(VLANClientState *vc, uint8_t macaddr[6]);
> > >  void qemu_check_nic_model(NICInfo *nd, const char *model);
> > >  void qemu_check_nic_model_list(NICInfo *nd, const char * const *models,
> > 
> > I've only just now noticed that we never actually made announce_self()
> > use this ... care to do that?
> > 
> Something like this:
> 
> ---
> Use qemu_send_packet_raw to send gracious arp. This will ensure that
> vnet header is handled properly.

Applied, thanks.


      parent reply	other threads:[~2009-10-15 22:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-26 10:03 Add qemu_send_raw() to vlan Gleb Natapov
2009-05-26 10:05 ` Avi Kivity
2009-05-26 10:08   ` Gleb Natapov
2009-05-26 10:11     ` Avi Kivity
2009-05-26 10:28       ` Mark McLoughlin
2009-05-26 10:34 ` Mark McLoughlin
2009-05-26 11:15   ` Avi Kivity
2009-05-26 12:05     ` Gleb Natapov
2009-05-26 12:20       ` Avi Kivity
2009-10-15  7:04 ` Mark McLoughlin
2009-10-15  7:33   ` Gleb Natapov
2009-10-15  7:36     ` Mark McLoughlin
2009-10-15 22:46     ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091015224644.GA17457@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).