From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH 1/3] introduce VMSTATE_U64 Date: Mon, 19 Oct 2009 22:38:11 -0200 Message-ID: <20091020003810.GY8092@mothafucka.localdomain> References: <1255721259-11740-1-git-send-email-glommer@redhat.com> <1255721259-11740-2-git-send-email-glommer@redhat.com> <4ADCF8EA.4060608@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Juan Quintela To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42704 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbZJTAiJ (ORCPT ); Mon, 19 Oct 2009 20:38:09 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9K0cEK1014046 for ; Mon, 19 Oct 2009 20:38:14 -0400 Content-Disposition: inline In-Reply-To: <4ADCF8EA.4060608@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 20, 2009 at 08:40:26AM +0900, Avi Kivity wrote: > On 10/17/2009 04:27 AM, Glauber Costa wrote: >> This is a patch actually written by Juan, which, according to him, >> he plans on posting to qemu.git. Problem is that linux defines >> u64 in a way that is type-uncompatible with uint64_t. >> >> I am including it here, because it is a dependency to my patch series >> that follows. >> >> > > Why can't we store these values in qemu as uint64_ts? Because then we have to redefine the whole structure in qemu. the proposal is to simply pick the structures directly from linux. I believe it is much easier, and the versioning scheme in vmstate will help us get around any changes they might suffer in the future.