From: Gleb Natapov <gleb@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH] move hlt exit to arch-specific code, and use upstream version.
Date: Tue, 20 Oct 2009 22:05:18 +0200 [thread overview]
Message-ID: <20091020200518.GH8278@redhat.com> (raw)
In-Reply-To: <20091020195635.GC8092@mothafucka.localdomain>
On Tue, Oct 20, 2009 at 05:56:35PM -0200, Glauber Costa wrote:
> On Tue, Oct 20, 2009 at 09:47:44PM +0200, Gleb Natapov wrote:
> > On Tue, Oct 20, 2009 at 05:15:32PM -0200, Glauber Costa wrote:
> > > HLT exit calls directly an arch-specific function. Furthermore,
> > > upstream qemu already places it on arch specific code, so let's follow it.
> > >
> > > The function that handles halt itself is almost equal between them. So
> > > let's use it.
> > >
> > kvm_handle_halt() may return 1. If it does kvm_arch_run() will return 1
> > too and kvm_run() will abort.
>
> kvm_arch_halt() may return 1 as well.
>
But it's called from another place and its return value is handled
differently.
--
Gleb.
prev parent reply other threads:[~2009-10-20 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 19:15 [PATCH] move hlt exit to arch-specific code, and use upstream version Glauber Costa
2009-10-20 19:47 ` Gleb Natapov
2009-10-20 19:56 ` Glauber Costa
2009-10-20 20:05 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020200518.GH8278@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox