From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] move hlt exit to arch-specific code, and use upstream version. Date: Tue, 20 Oct 2009 22:05:18 +0200 Message-ID: <20091020200518.GH8278@redhat.com> References: <1256066132-13801-1-git-send-email-glommer@redhat.com> <20091020194744.GG8278@redhat.com> <20091020195635.GC8092@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33258 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbZJTUFR (ORCPT ); Tue, 20 Oct 2009 16:05:17 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9KK5LtU023049 for ; Tue, 20 Oct 2009 16:05:22 -0400 Content-Disposition: inline In-Reply-To: <20091020195635.GC8092@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 20, 2009 at 05:56:35PM -0200, Glauber Costa wrote: > On Tue, Oct 20, 2009 at 09:47:44PM +0200, Gleb Natapov wrote: > > On Tue, Oct 20, 2009 at 05:15:32PM -0200, Glauber Costa wrote: > > > HLT exit calls directly an arch-specific function. Furthermore, > > > upstream qemu already places it on arch specific code, so let's follow it. > > > > > > The function that handles halt itself is almost equal between them. So > > > let's use it. > > > > > kvm_handle_halt() may return 1. If it does kvm_arch_run() will return 1 > > too and kvm_run() will abort. > > kvm_arch_halt() may return 1 as well. > But it's called from another place and its return value is handled differently. -- Gleb.