From: Max Laier <max@love2party.net>
To: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: KVM: VMX: flush TLB with INVEPT on cpu migration
Date: Wed, 21 Oct 2009 03:18:26 +0200 [thread overview]
Message-ID: <200910210318.27624.max@love2party.net> (raw)
In-Reply-To: <20091001221658.GA22916@amt.cnet>
On Friday 02 October 2009 00:16:58 you wrote:
> It is possible that stale EPTP-tagged mappings are used, if a
> vcpu migrates to a different pcpu.
>
> Set KVM_REQ_TLB_FLUSH in vmx_vcpu_load, when switching pcpus, which
> will invalidate both VPID and EPT mappings on the next vm-entry.
Thank you - I was at the brink of a nervous break-down before discovering
this. Maybe it would help for the future to add a comment to
ept_misconfig_inspect_spte that explains that this might be caused by out of
sync tlbs, too (esp. when it doesn't show an apparent cause of the misconfig)
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index e86f1a6..97f4265 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -708,7 +708,7 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu, int
> cpu) if (vcpu->cpu != cpu) {
> vcpu_clear(vmx);
> kvm_migrate_timers(vcpu);
> - vpid_sync_vcpu_all(vmx);
> + set_bit(KVM_REQ_TLB_FLUSH, &vcpu->requests);
> local_irq_disable();
> list_add(&vmx->local_vcpus_link,
> &per_cpu(vcpus_on_cpu, cpu));
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> !DSPAM:4ac52dbb832371894110002!
>
--
/"\ Best regards, | mlaier@freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier@EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
next prev parent reply other threads:[~2009-10-21 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 22:16 KVM: VMX: flush TLB with INVEPT on cpu migration Marcelo Tosatti
2009-10-02 20:56 ` Ram Pai
2009-10-21 1:18 ` Max Laier [this message]
2009-10-22 15:10 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910210318.27624.max@love2party.net \
--to=max@love2party.net \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).