From: Marcelo Tosatti <mtosatti@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
kvm-ppc <kvm-ppc@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] Enable 32bit dirty log pointers on 64bit host
Date: Thu, 22 Oct 2009 18:39:53 -0200 [thread overview]
Message-ID: <20091022203953.GA20630@amt.cnet> (raw)
In-Reply-To: <1256134109-14292-1-git-send-email-agraf@suse.de>
On Wed, Oct 21, 2009 at 04:08:29PM +0200, Alexander Graf wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With big endian userspace, we can't quite figure out if a pointer
> is 32 bit (shifted >> 32) or 64 bit when we read a 64 bit pointer.
>
> This is what happens with dirty logging. To get the pointer interpreted
> correctly, we thus need Arnd's patch to implement a compat layer for
> the ioctl:
>
> A better way to do this is to add a separate compat_ioctl() method that
> converts this for you.
>
> From: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexander Graf <agraf@suse.de>
>
> ---
>
> Changes from Arnd's example version:
>
> - s/log.log/log/ (Avi)
> - use sizeof(compat_log) (Avi)
> - compile fixes
Applied, thanks.
next prev parent reply other threads:[~2009-10-22 20:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 14:08 [PATCH] Enable 32bit dirty log pointers on 64bit host Alexander Graf
2009-10-22 10:23 ` Avi Kivity
2009-10-22 10:25 ` Alexander Graf
[not found] ` <03CB8BC3-B33F-4253-A259-A1517A099698-l3A5Bk7waGM@public.gmane.org>
2009-10-22 10:32 ` Avi Kivity
2009-10-22 20:39 ` Marcelo Tosatti [this message]
2009-10-23 8:41 ` Jan Kiszka
[not found] ` <4AE16C50.1060806-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2009-10-23 9:12 ` Alexander Graf
2009-10-23 9:15 ` Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2009-10-22 12:19 Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022203953.GA20630@amt.cnet \
--to=mtosatti@redhat.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox