From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] Enable 32bit dirty log pointers on 64bit host Date: Thu, 22 Oct 2009 18:39:53 -0200 Message-ID: <20091022203953.GA20630@amt.cnet> References: <1256134109-14292-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, Avi Kivity , kvm-ppc , Arnd Bergmann To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55325 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756645AbZJVU5o (ORCPT ); Thu, 22 Oct 2009 16:57:44 -0400 Content-Disposition: inline In-Reply-To: <1256134109-14292-1-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 21, 2009 at 04:08:29PM +0200, Alexander Graf wrote: > From: Arnd Bergmann > > With big endian userspace, we can't quite figure out if a pointer > is 32 bit (shifted >> 32) or 64 bit when we read a 64 bit pointer. > > This is what happens with dirty logging. To get the pointer interpreted > correctly, we thus need Arnd's patch to implement a compat layer for > the ioctl: > > A better way to do this is to add a separate compat_ioctl() method that > converts this for you. > > From: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Acked-by: Alexander Graf > > --- > > Changes from Arnd's example version: > > - s/log.log/log/ (Avi) > - use sizeof(compat_log) (Avi) > - compile fixes Applied, thanks.