From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCHv2] virtio: order used ring after used index read
Date: Mon, 26 Oct 2009 10:25:38 +1030 [thread overview]
Message-ID: <200910261025.38950.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20091025132853.GA21301@redhat.com>
On Sun, 25 Oct 2009 11:58:53 pm Michael S. Tsirkin wrote:
> On SMP guests, reads from the ring might bypass
> used index reads. This causes guest crashes
> because host writes to used index to signal ring data
> readiness.
> Fix this by inserting rmb before used ring reads.
Thanks, good spotting. Applied.
Rusty.
prev parent reply other threads:[~2009-10-25 23:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-25 13:28 [PATCHv2] virtio: order used ring after used index read Michael S. Tsirkin
2009-10-25 23:55 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910261025.38950.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox