From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCHv2] virtio: order used ring after used index read
Date: Mon, 26 Oct 2009 10:25:38 +1030
Message-ID: <200910261025.38950.rusty@rustcorp.com.au>
References: <20091025132853.GA21301@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:52106 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753951AbZJYXzh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 25 Oct 2009 19:55:37 -0400
In-Reply-To: <20091025132853.GA21301@redhat.com>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, 25 Oct 2009 11:58:53 pm Michael S. Tsirkin wrote:
> On SMP guests, reads from the ring might bypass
> used index reads. This causes guest crashes
> because host writes to used index to signal ring data
> readiness.
> Fix this by inserting rmb before used ring reads.

Thanks, good spotting.  Applied.

Rusty.