From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 3/4] scsi-disk: Factor out SCSI command emulation Date: Wed, 28 Oct 2009 09:42:47 +0100 Message-ID: <20091028084247.GC17601@lst.de> References: <20091027152859.C6CF739742@ochil.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org To: Hannes Reinecke Return-path: Received: from verein.lst.de ([213.95.11.210]:34740 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932695AbZJ1Imt (ORCPT ); Wed, 28 Oct 2009 04:42:49 -0400 Content-Disposition: inline In-Reply-To: <20091027152859.C6CF739742@ochil.suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Oct 27, 2009 at 04:28:59PM +0100, Hannes Reinecke wrote: > > Other drives might want to use SCSI command emulation without > going through the SCSI disk abstraction, as this imposes too > many limits on the emulation. Might be a good idea to move something like this first into the series and share the CDB decoder between scsi and ide (atapi) as a start. A little bit of refactoring of the CDB decoder, e.g. into one function per opcode (-family) won't hurt either.