From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [PATCH] [RFC] KVM test: Major control file cleanup Date: Wed, 28 Oct 2009 13:18:50 -0500 Message-ID: <20091028181850.GU13808@us.ibm.com> References: <1256728483.2946.3.camel@localhost.localdomain> <382425334.1152431256744581206.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Lucas Meneghel Rodrigues , kvm@vger.kernel.org, uril@redhat.com, autotest@test.kernel.org To: Michael Goldish Return-path: Received: from e2.ny.us.ibm.com ([32.97.182.142]:55335 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841AbZJ1SSv (ORCPT ); Wed, 28 Oct 2009 14:18:51 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by e2.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9SIBO8Q019220 for ; Wed, 28 Oct 2009 14:11:24 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9SIIthQ1417396 for ; Wed, 28 Oct 2009 14:18:55 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id n9SIIte3007492 for ; Wed, 28 Oct 2009 14:18:55 -0400 Content-Disposition: inline In-Reply-To: <382425334.1152431256744581206.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Michael Goldish [2009-10-28 10:43]: > > ----- "Lucas Meneghel Rodrigues" wrote: > > > One thing that just occurred to me is, if we have a test config > > "library" as you said, it's perfectly possible to put the actual test > > set definitions and other config files inside the control file as > > strings. This way one can control configuration inside the control > > file, > > making it more convenient for usage, let's say, inside the autotest > > web > > interface. Since the control file would be reduced in size, the > > configuration snippets being in the control file would not be a huge > > problem, while keeping the original autotest philosophy of keeping > > stuff inside the control file... What do you think? > > Sounds great, except it won't allow you to debug your configuration > using kvm_config.py. So the question now is what's more important -- > the ability to debug or ease of use when running from the server. +1 debug When creating new test scenarios I make *heavy* use of kvm_config.py; I'd be lost without being able to debug test configuration files. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com