From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 17:03:47 +0200 Message-ID: <20091029150347.GA4913@redhat.com> References: <1256807803.10825.39.camel@blaa> <20091029122334.GB3478@redhat.com> <4AE9A8DE.1070609@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mark McLoughlin , Dustin Kirkland , qemu-devel@nongnu.org, kvm@vger.kernel.org, Anthony Liguori , Scott Tsai To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59235 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754065AbZJ2PGP (ORCPT ); Thu, 29 Oct 2009 11:06:15 -0400 Content-Disposition: inline In-Reply-To: <4AE9A8DE.1070609@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Oct 29, 2009 at 04:38:22PM +0200, Avi Kivity wrote: > On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: >> On Thu, Oct 29, 2009 at 09:16:43AM +0000, Mark McLoughlin wrote: >> >>> I agree we shouldn't exit in this scenario >>> >> virtio in qemu generally seems to handle guest errors >> by calling exit(2). This probably makes it easier to notice >> the problems, but is likely not the right thing to do. >> > > Right, the thinking was the guest is shooting itself in the foot and > hitting, but a guest can delegate control of a device to unprivileged > code (for example device assignment in kvm), When we emulate iommu, yes. > which would allow this unprivileged code to kill the guest. With usb emulation, we can have: drivers/usb/class/usblp.c:343:static const char *usblp_messages[] = { "ok", "out of paper", "off-line", "on fire" }; > -- > error compiling committee.c: too many arguments to function