From: Ryan Harper <ryanh@us.ibm.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: Ryan Harper <ryanh@us.ibm.com>,
Michael Goldish <mgoldish@redhat.com>,
autotest@test.kernel.org, uril@redhat.com, kvm@vger.kernel.org
Subject: Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup
Date: Fri, 30 Oct 2009 08:54:31 -0500 [thread overview]
Message-ID: <20091030135431.GL13808@us.ibm.com> (raw)
In-Reply-To: <6ac58f4f0910281247r3a383c16iccac046d214e9a46@mail.gmail.com>
* Lucas Meneghel Rodrigues <lmr@redhat.com> [2009-10-28 14:48]:
> Ryan, Michael:
>
> I absolutely agree that the ability to debug stuff is important, but
> the ability to make things straightforward to use from the web
> interface or cli is also important. A longer term goal is to have our
> test farm and make any developer able to schedule a job on the test
> farm easily and conveniently.
>
> Having the dictionaries generated on the job debug directory seems
> like a good compromise to me. Also we can come up with a smart way of
> parsing the config file generated by a given control file in a similar
> way we do today with kvm_config.py, it shouldn't be that hard to do
> it... (I hope I won't burn my tongue with this statement).
If I'm understanding things, we are talking about moving the large body
of kvm_tests.cfg test definitions, guest definitions into a "library",
and then moving the requested test config (bottom on kvm_tests.cfg) into
the control file itself which means the autotest webui would be able to
control which tests get run; I like this idea very well. My concern
that I mentioned is that as you edit the "library" it can be difficult
to ensure you described exactly which set of tests on which guests you
want to run and kvm_config.py is invaluable in the process of getting it
right.
Why not have kvm_config.py , or some other wrapper generate a
"kvm_tests.cfg" file dynamically from the "library" and the strings from
the control file? That way we could still debug configuration via
kvm_config.py? I much perfer this over queueing up jobs in the webiu,
waiting for it to run, checking the results in the DEBUG dir, adjusting,
repeat.
--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com
next prev parent reply other threads:[~2009-10-30 13:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <393106486.1126051256722865111.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-10-28 9:48 ` [PATCH] [RFC] KVM test: Major control file cleanup Michael Goldish
2009-10-28 11:14 ` Lucas Meneghel Rodrigues
2009-10-28 15:43 ` Michael Goldish
2009-10-28 15:58 ` [Autotest] " Lucas Meneghel Rodrigues
2009-10-28 18:18 ` Ryan Harper
2009-10-28 19:47 ` [Autotest] " Lucas Meneghel Rodrigues
2009-10-28 20:48 ` Michael Goldish
2009-10-30 13:54 ` Ryan Harper [this message]
2009-10-30 14:36 ` Lucas Meneghel Rodrigues
2009-10-28 15:57 ` Michael Goldish
2009-10-28 15:59 ` [Autotest] " Lucas Meneghel Rodrigues
[not found] <630174680.1165391256752423162.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-10-28 18:04 ` Michael Goldish
2009-11-04 7:25 ` Yolkfull Chow
2009-11-04 12:33 ` Lucas Meneghel Rodrigues
[not found] <1285393002.1333521257019268689.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-10-31 20:01 ` Michael Goldish
2009-11-02 22:10 ` Ryan Harper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030135431.GL13808@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lmr@redhat.com \
--cc=mgoldish@redhat.com \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox