From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [Autotest] [PATCH] [RFC] KVM test: Major control file cleanup Date: Fri, 30 Oct 2009 08:54:31 -0500 Message-ID: <20091030135431.GL13808@us.ibm.com> References: <1256728483.2946.3.camel@localhost.localdomain> <382425334.1152431256744581206.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <20091028181850.GU13808@us.ibm.com> <6ac58f4f0910281247r3a383c16iccac046d214e9a46@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ryan Harper , Michael Goldish , autotest@test.kernel.org, uril@redhat.com, kvm@vger.kernel.org To: Lucas Meneghel Rodrigues Return-path: Received: from e35.co.us.ibm.com ([32.97.110.153]:52471 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932081AbZJ3NzB (ORCPT ); Fri, 30 Oct 2009 09:55:01 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9UDhkek020846 for ; Fri, 30 Oct 2009 07:43:47 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9UDskhU104194 for ; Fri, 30 Oct 2009 07:54:47 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id n9U7r4LD003958 for ; Fri, 30 Oct 2009 01:53:04 -0600 Content-Disposition: inline In-Reply-To: <6ac58f4f0910281247r3a383c16iccac046d214e9a46@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: * Lucas Meneghel Rodrigues [2009-10-28 14:48]: > Ryan, Michael: > > I absolutely agree that the ability to debug stuff is important, but > the ability to make things straightforward to use from the web > interface or cli is also important. A longer term goal is to have our > test farm and make any developer able to schedule a job on the test > farm easily and conveniently. > > Having the dictionaries generated on the job debug directory seems > like a good compromise to me. Also we can come up with a smart way of > parsing the config file generated by a given control file in a similar > way we do today with kvm_config.py, it shouldn't be that hard to do > it... (I hope I won't burn my tongue with this statement). If I'm understanding things, we are talking about moving the large body of kvm_tests.cfg test definitions, guest definitions into a "library", and then moving the requested test config (bottom on kvm_tests.cfg) into the control file itself which means the autotest webui would be able to control which tests get run; I like this idea very well. My concern that I mentioned is that as you edit the "library" it can be difficult to ensure you described exactly which set of tests on which guests you want to run and kvm_config.py is invaluable in the process of getting it right. Why not have kvm_config.py , or some other wrapper generate a "kvm_tests.cfg" file dynamically from the "library" and the strings from the control file? That way we could still debug configuration via kvm_config.py? I much perfer this over queueing up jobs in the webiu, waiting for it to run, checking the results in the DEBUG dir, adjusting, repeat. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com