From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Glauber Costa <glommer@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: error while loading state for instance 0x0 of device 'kvmclock'
Date: Mon, 2 Nov 2009 10:29:32 -0200 [thread overview]
Message-ID: <20091102122932.GA2856@amt.cnet> (raw)
In-Reply-To: <4AEEB456.1000006@siemens.com>
On Mon, Nov 02, 2009 at 11:28:38AM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Hi,
> >
> > current qemu-kvm.git gives me the message "qemu: warning: error while
> > loading state for instance 0x0 of device 'kvmclock'" when I run a simple
> > "savevm" followed by a "loadvm 1". What's broken here?
>
> OK, this is due to "KVM: add flags to kvm_clock_data" (958b0c5497): the
> flags field is not cleared on KVM_SET_CLOCK. Will post a fix.
>
> But the above kernel commit is also broken: KVM_GET_CLOCK checks
> uninitialized user_ns.flags (probably instead of the user's value). This
> raises the question if the caller of KVM_GET_CLOCK is also supposed to
> pass kvm_clock_data with flags cleared down to the kernel. Could someone
> clarify this so I could fix it accordingly?
Yes userspace is supposed to clear flags. My bad.
next prev parent reply other threads:[~2009-11-02 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 8:36 error while loading state for instance 0x0 of device 'kvmclock' Jan Kiszka
2009-11-02 10:28 ` Jan Kiszka
2009-11-02 12:29 ` Marcelo Tosatti [this message]
2009-11-02 13:36 ` Avi Kivity
2009-11-02 15:37 ` Jan Kiszka
2009-11-03 10:54 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102122932.GA2856@amt.cnet \
--to=mtosatti@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox