From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: error while loading state for instance 0x0 of device 'kvmclock'
Date: Mon, 2 Nov 2009 10:29:32 -0200
Message-ID: <20091102122932.GA2856@amt.cnet>
References: <4AEE99F5.5000509@web.de> <4AEEB456.1000006@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Glauber Costa <glommer@redhat.com>, kvm <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:32312 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755212AbZKBOaE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 2 Nov 2009 09:30:04 -0500
Content-Disposition: inline
In-Reply-To: <4AEEB456.1000006@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Nov 02, 2009 at 11:28:38AM +0100, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Hi,
> > 
> > current qemu-kvm.git gives me the message "qemu: warning: error while
> > loading state for instance 0x0 of device 'kvmclock'" when I run a simple
> > "savevm" followed by a "loadvm 1". What's broken here?
> 
> OK, this is due to "KVM: add flags to kvm_clock_data" (958b0c5497): the
> flags field is not cleared on KVM_SET_CLOCK. Will post a fix.
> 
> But the above kernel commit is also broken: KVM_GET_CLOCK checks
> uninitialized user_ns.flags (probably instead of the user's value). This
> raises the question if the caller of KVM_GET_CLOCK is also supposed to
> pass kvm_clock_data with flags cleared down to the kernel. Could someone
> clarify this so I could fix it accordingly?

Yes userspace is supposed to clear flags. My bad.