[KVM-AUTOTEST][PATCH] Fix kvm_config.py -f <filename> mode

[KVM-AUTOTEST][PATCH] Fix kvm_config.py -f <filename> mode

[Ryan Harper]

kvm_config.py supports specifying a different filename for
test config.  This patch fixes the option parsing parameters.
Currently it uses 'store_true' which stores the value True into
the filename variable; we want the 'store' mode which will store
the value of the option (aka, the filename) in the variable.

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>

diff --git a/client/tests/kvm/kvm_config.py b/client/tests/kvm/kvm_config.py
index 3114c07..52de4c7 100755
--- a/client/tests/kvm/kvm_config.py
+++ b/client/tests/kvm/kvm_config.py
@@ -501,7 +501,7 @@ class config:
 
 if __name__ == "__main__":
     parser = optparse.OptionParser()
-    parser.add_option('-f', '--file', dest="filename", action='store_true',
+    parser.add_option('-f', '--file', dest="filename", action='store',
                       help='path to a config file that will be parsed. '
                            'If not specified, will parse kvm_tests.cfg '
                            'located inside the kvm test dir.')



-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com

Re: [KVM-AUTOTEST][PATCH] Fix kvm_config.py -f <filename> mode

[Lucas Meneghel Rodrigues]

Ooops, fixed. Thanks Ryan!

On Mon, Nov 2, 2009 at 9:28 PM, Ryan Harper <ryanh@us.ibm.com> wrote:
> kvm_config.py supports specifying a different filename for
> test config.  This patch fixes the option parsing parameters.
> Currently it uses 'store_true' which stores the value True into
> the filename variable; we want the 'store' mode which will store
> the value of the option (aka, the filename) in the variable.
>
> Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
>
> diff --git a/client/tests/kvm/kvm_config.py b/client/tests/kvm/kvm_config.py
> index 3114c07..52de4c7 100755
> --- a/client/tests/kvm/kvm_config.py
> +++ b/client/tests/kvm/kvm_config.py
> @@ -501,7 +501,7 @@ class config:
>
>  if __name__ == "__main__":
>     parser = optparse.OptionParser()
> -    parser.add_option('-f', '--file', dest="filename", action='store_true',
> +    parser.add_option('-f', '--file', dest="filename", action='store',
>                       help='path to a config file that will be parsed. '
>                            'If not specified, will parse kvm_tests.cfg '
>                            'located inside the kvm test dir.')
>
>
>
> --
> Ryan Harper
> Software Engineer; Linux Technology Center
> IBM Corp., Austin, Tx
> ryanh@us.ibm.com
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Lucas