From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot by triple fault) Date: Fri, 20 Nov 2009 09:55:42 -0600 Message-ID: <20091120155542.GQ27346@us.ibm.com> References: <20091111192947.348198723@localhost.localdomain> <20091112122124.GB7392@redhat.com> <4AFC027B.1090101@siemens.com> <20091112130542.GD7392@redhat.com> <4AFFFA10.9020407@redhat.com> <20091119155407.GE3193@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Jan Kiszka , Marcelo Tosatti , kvm@vger.kernel.org, joerg.roedel@amd.com To: Gleb Natapov Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:56795 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753795AbZKTP4O (ORCPT ); Fri, 20 Nov 2009 10:56:14 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id nAKFottd002720 for ; Fri, 20 Nov 2009 08:50:55 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nAKFtw8u216852 for ; Fri, 20 Nov 2009 08:56:00 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nAK8mpI5026885 for ; Fri, 20 Nov 2009 01:48:52 -0700 Content-Disposition: inline In-Reply-To: <20091119155407.GE3193@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Gleb Natapov [2009-11-19 09:55]: > > It's actually less readable. I know 11 is between 10 and 13, but is > > NP_VECTOR between TS_VECTOR and GP_VECTOR? > > > > This is better as a switch, or even: > > > > u8 exception_class[] = { > > [PF_VECTOR] EXPT_PF, > > > > etc. > OK what about this then: Is there a consensus on this yet? I'm tracking this issue and didn't see anything get committed yet. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com