From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [patch 0/2] Handle multiple exceptions (fixes Win2003 reboot by triple fault) Date: Wed, 25 Nov 2009 11:03:16 -0200 Message-ID: <20091125130316.GB5007@amt.cnet> References: <20091111192947.348198723@localhost.localdomain> <20091112122124.GB7392@redhat.com> <4AFC027B.1090101@siemens.com> <20091112130542.GD7392@redhat.com> <4AFFFA10.9020407@redhat.com> <20091119155407.GE3193@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Jan Kiszka , kvm@vger.kernel.org, joerg.roedel@amd.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1025 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934622AbZKYNDe (ORCPT ); Wed, 25 Nov 2009 08:03:34 -0500 Content-Disposition: inline In-Reply-To: <20091119155407.GE3193@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 19, 2009 at 05:54:07PM +0200, Gleb Natapov wrote: > > It's actually less readable. I know 11 is between 10 and 13, but is > > NP_VECTOR between TS_VECTOR and GP_VECTOR? > > > > This is better as a switch, or even: > > > > u8 exception_class[] = { > > [PF_VECTOR] EXPT_PF, > > > > etc. > OK what about this then: > > From: Eddie Dong > > Move Double-Fault generation logic out of page fault > exception generating function to cover more generic case. > > Signed-off-by: Eddie Dong > Signed-off-by: Gleb Natapov Applied this and TSS exceptions, thanks.