* [PATCH] qemu-kvm: fix __user export
@ 2009-11-30 12:02 Michael S. Tsirkin
2009-12-02 13:04 ` Avi Kivity
2009-12-02 13:09 ` Christian Borntraeger
0 siblings, 2 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2009-11-30 12:02 UTC (permalink / raw)
To: kvm, avi
__user macro does not appear in exported headers
and should not be in headers qemu-kvm includes.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
kvm/include/linux/kvm.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h
index 92045a9..db10887 100644
--- a/kvm/include/linux/kvm.h
+++ b/kvm/include/linux/kvm.h
@@ -309,7 +309,7 @@ struct kvm_dirty_log {
__u32 slot;
__u32 padding1;
union {
- void __user *dirty_bitmap; /* one bit per page */
+ void *dirty_bitmap; /* one bit per page */
__u64 padding2;
};
};
--
1.6.5.2.143.g8cc62
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-kvm: fix __user export
2009-11-30 12:02 [PATCH] qemu-kvm: fix __user export Michael S. Tsirkin
@ 2009-12-02 13:04 ` Avi Kivity
2009-12-02 13:09 ` Christian Borntraeger
1 sibling, 0 replies; 5+ messages in thread
From: Avi Kivity @ 2009-12-02 13:04 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm
On 11/30/2009 02:02 PM, Michael S. Tsirkin wrote:
> __user macro does not appear in exported headers
> and should not be in headers qemu-kvm includes.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-kvm: fix __user export
2009-11-30 12:02 [PATCH] qemu-kvm: fix __user export Michael S. Tsirkin
2009-12-02 13:04 ` Avi Kivity
@ 2009-12-02 13:09 ` Christian Borntraeger
2009-12-02 13:16 ` Avi Kivity
1 sibling, 1 reply; 5+ messages in thread
From: Christian Borntraeger @ 2009-12-02 13:09 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: kvm, avi
Am Montag 30 November 2009 13:02:08 schrieb Michael S. Tsirkin:
> __user macro does not appear in exported headers
> and should not be in headers qemu-kvm includes.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> kvm/include/linux/kvm.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h
> index 92045a9..db10887 100644
> --- a/kvm/include/linux/kvm.h
> +++ b/kvm/include/linux/kvm.h
> @@ -309,7 +309,7 @@ struct kvm_dirty_log {
> __u32 slot;
> __u32 padding1;
> union {
> - void __user *dirty_bitmap; /* one bit per page */
> + void *dirty_bitmap; /* one bit per page */
> __u64 padding2;
> };
> };
>
Huh?
Doesnt that create a sparse warning? You already mention that the exported
header does not contain __user and that is perfectly ok:
- for the kernel dirty_bitmap is in the user address space, so we need the __user
- userspace does not know and need the __user so it is removed during
headers_install.
Christian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-kvm: fix __user export
2009-12-02 13:09 ` Christian Borntraeger
@ 2009-12-02 13:16 ` Avi Kivity
2009-12-02 13:20 ` Christian Borntraeger
0 siblings, 1 reply; 5+ messages in thread
From: Avi Kivity @ 2009-12-02 13:16 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: Michael S. Tsirkin, kvm
On 12/02/2009 03:09 PM, Christian Borntraeger wrote:
> Am Montag 30 November 2009 13:02:08 schrieb Michael S. Tsirkin:
>
>> __user macro does not appear in exported headers
>> and should not be in headers qemu-kvm includes.
>>
>> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>> ---
>> kvm/include/linux/kvm.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h
>> index 92045a9..db10887 100644
>> --- a/kvm/include/linux/kvm.h
>> +++ b/kvm/include/linux/kvm.h
>> @@ -309,7 +309,7 @@ struct kvm_dirty_log {
>> __u32 slot;
>> __u32 padding1;
>> union {
>> - void __user *dirty_bitmap; /* one bit per page */
>> + void *dirty_bitmap; /* one bit per page */
>> __u64 padding2;
>> };
>> };
>>
>>
> Huh?
> Doesnt that create a sparse warning? You already mention that the exported
> header does not contain __user and that is perfectly ok:
> - for the kernel dirty_bitmap is in the user address space, so we need the __user
> - userspace does not know and need the __user so it is removed during
> headers_install.
>
>
This is in the copy of the headers that qemu-kvm.git carries, not the
kernel master.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-kvm: fix __user export
2009-12-02 13:16 ` Avi Kivity
@ 2009-12-02 13:20 ` Christian Borntraeger
0 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2009-12-02 13:20 UTC (permalink / raw)
To: Avi Kivity; +Cc: Michael S. Tsirkin, kvm
> This is in the copy of the headers that qemu-kvm.git carries, not the
> kernel master.
Right, I missed that. Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-12-02 13:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-30 12:02 [PATCH] qemu-kvm: fix __user export Michael S. Tsirkin
2009-12-02 13:04 ` Avi Kivity
2009-12-02 13:09 ` Christian Borntraeger
2009-12-02 13:16 ` Avi Kivity
2009-12-02 13:20 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox