From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 03/12] Remove KVM_REQ_PENDING_TIMER. Date: Wed, 2 Dec 2009 02:59:02 -0200 Message-ID: <20091202045902.GA21575@amt.cnet> References: <1259678201-11203-1-git-send-email-clalance@redhat.com> <1259678201-11203-4-git-send-email-clalance@redhat.com> <4B1568AF.6010100@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Lalancette , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17915 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbZLBFOd (ORCPT ); Wed, 2 Dec 2009 00:14:33 -0500 Content-Disposition: inline In-Reply-To: <4B1568AF.6010100@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Dec 01, 2009 at 08:04:15PM +0100, Jan Kiszka wrote: > Chris Lalancette wrote: > > KVM_REQ_PENDING_TIMER is set and cleared in a couple of places, > > but it never seems to be actually checked. Remove it. > > > > I would suggest to study the introducing commit > 06e05645661211b9eaadaf6344c335d2e80f0ba2. My strong feeling is that this > removal is wrong. Right.