From: Marcelo Tosatti <mtosatti@redhat.com>
To: Chris Lalancette <clalance@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 08/12] Remove timer.c
Date: Wed, 2 Dec 2009 03:11:35 -0200 [thread overview]
Message-ID: <20091202051135.GC21575@amt.cnet> (raw)
In-Reply-To: <1259678201-11203-9-git-send-email-clalance@redhat.com>
On Tue, Dec 01, 2009 at 03:36:37PM +0100, Chris Lalancette wrote:
> The code in timer.c isn't really similar enough between
> the i8254 and the lapic to share. Split these into
> separate functions, and remove timer.c
>
> Signed-off-by: Chris Lalancette <clalance@redhat.com>
There should be one function. Abstract the wake up waitqueue (which
requires a vcpu) for lapic and kvm_set_irq/whatever for PIT into
per-timer callback please.
next prev parent reply other threads:[~2009-12-02 5:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 14:36 [PATCH 0/12]: Fix kdump under KVM Chris Lalancette
2009-12-01 14:36 ` [PATCH 01/12] Fix up some comments around the source tree Chris Lalancette
2009-12-01 14:36 ` [PATCH 02/12] Make kvm_pic_reset static Chris Lalancette
2009-12-01 14:36 ` [PATCH 03/12] Remove KVM_REQ_PENDING_TIMER Chris Lalancette
2009-12-01 19:04 ` Jan Kiszka
2009-12-02 4:59 ` Marcelo Tosatti
2009-12-02 12:59 ` Chris Lalancette
2009-12-02 14:16 ` Avi Kivity
2009-12-02 14:22 ` Avi Kivity
2009-12-01 14:36 ` [PATCH 04/12] IOAPIC timer interrupt redirect Chris Lalancette
2009-12-02 5:03 ` Marcelo Tosatti
2009-12-01 14:36 ` [PATCH 05/12] Make the IOAPIC lock a spinlock Chris Lalancette
2009-12-02 14:27 ` Avi Kivity
2009-12-01 14:36 ` [PATCH 06/12] Make the PIC use interrupt safe locking Chris Lalancette
2009-12-01 14:36 ` [PATCH 07/12] Rename kvm_apic_accept_pic_intr Chris Lalancette
2009-12-02 14:24 ` Avi Kivity
2009-12-02 16:12 ` Gleb Natapov
2009-12-01 14:36 ` [PATCH 08/12] Remove timer.c Chris Lalancette
2009-12-02 5:11 ` Marcelo Tosatti [this message]
2009-12-01 14:36 ` [PATCH 09/12] Fix missing spin_lock in PIT timer Chris Lalancette
2009-12-01 14:36 ` [PATCH 10/12] Inject i8254 interrupts directly from hrtimer callback Chris Lalancette
2009-12-01 14:36 ` [PATCH 11/12] Allow the PIC to signal CPUs other than BSP Chris Lalancette
2009-12-01 14:36 ` [PATCH 12/12] Kick appropriate CPUs when signalling interrupts Chris Lalancette
2009-12-02 15:44 ` Gleb Natapov
2009-12-08 10:48 ` Chris Lalancette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202051135.GC21575@amt.cnet \
--to=mtosatti@redhat.com \
--cc=clalance@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox