From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 08/12] Remove timer.c
Date: Wed, 2 Dec 2009 03:11:35 -0200
Message-ID: <20091202051135.GC21575@amt.cnet>
References: <1259678201-11203-1-git-send-email-clalance@redhat.com> <1259678201-11203-9-git-send-email-clalance@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Chris Lalancette <clalance@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:44649 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751160AbZLBFOb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 2 Dec 2009 00:14:31 -0500
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB25EcaQ031170
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Wed, 2 Dec 2009 00:14:38 -0500
Content-Disposition: inline
In-Reply-To: <1259678201-11203-9-git-send-email-clalance@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Dec 01, 2009 at 03:36:37PM +0100, Chris Lalancette wrote:
> The code in timer.c isn't really similar enough between
> the i8254 and the lapic to share.  Split these into
> separate functions, and remove timer.c
> 
> Signed-off-by: Chris Lalancette <clalance@redhat.com>

There should be one function. Abstract the wake up waitqueue (which
requires a vcpu) for lapic and kvm_set_irq/whatever for PIT into
per-timer callback please.