From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec compliant Date: Wed, 2 Dec 2009 15:33:06 +0200 Message-ID: <20091202133306.GA18193@redhat.com> References: <20091130190226.GB457@redhat.com> <4B166311.7040300@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel , Juan Quintela To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45469 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbZLBNfu (ORCPT ); Wed, 2 Dec 2009 08:35:50 -0500 Content-Disposition: inline In-Reply-To: <4B166311.7040300@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Dec 02, 2009 at 02:52:33PM +0200, Avi Kivity wrote: > On 11/30/2009 09:02 PM, Michael S. Tsirkin wrote: >> PCI memory should be disabled at reset, otherwise >> we might claim transactions at address 0. >> I/O should also be disabled, although for cirrus >> it is harmless to enable it as we do not >> have I/O bar. >> >> Note: bios fix needed for this patch to work >> was already applied: >> previously bios incorrently assumed that it does not >> need to enable i/o unless device has i/o bar. >> > > Is this for qemu-kvm.git or qemu.git? > > -- > error compiling committee.c: too many arguments to function This for qemu.git -- MST