Re: [PATCH] qemu-kvm: fix __user export

[Christian Borntraeger <borntraeger@de.ibm.com>]

Am Montag 30 November 2009 13:02:08 schrieb Michael S. Tsirkin:
> __user macro does not appear in exported headers
> and should not be in headers qemu-kvm includes.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  kvm/include/linux/kvm.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h
> index 92045a9..db10887 100644
> --- a/kvm/include/linux/kvm.h
> +++ b/kvm/include/linux/kvm.h
> @@ -309,7 +309,7 @@ struct kvm_dirty_log {
>  	__u32 slot;
>  	__u32 padding1;
>  	union {
> -		void __user *dirty_bitmap; /* one bit per page */
> +		void *dirty_bitmap; /* one bit per page */
>  		__u64 padding2;
>  	};
>  };
> 
Huh?
Doesnt that create a sparse warning? You already mention that the exported
header does not contain __user and that is perfectly ok:
- for the kernel dirty_bitmap is in the user address space, so we need the __user
- userspace does not know and need the __user so it is removed during 
  headers_install.

Christian