From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH] qemu-kvm: fix __user export Date: Wed, 2 Dec 2009 14:09:28 +0100 Message-ID: <200912021409.28573.borntraeger@de.ibm.com> References: <20091130120207.GA26942@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, avi@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mtagate6.uk.ibm.com ([194.196.100.166]:43128 "EHLO mtagate6.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752929AbZLBNJY (ORCPT ); Wed, 2 Dec 2009 08:09:24 -0500 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id nB2D9U4l004918 for ; Wed, 2 Dec 2009 13:09:30 GMT Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nB2D9TQH720946 for ; Wed, 2 Dec 2009 13:09:30 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id nB2D9T1o014523 for ; Wed, 2 Dec 2009 13:09:29 GMT In-Reply-To: <20091130120207.GA26942@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Am Montag 30 November 2009 13:02:08 schrieb Michael S. Tsirkin: > __user macro does not appear in exported headers > and should not be in headers qemu-kvm includes. > > Signed-off-by: Michael S. Tsirkin > --- > kvm/include/linux/kvm.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kvm/include/linux/kvm.h b/kvm/include/linux/kvm.h > index 92045a9..db10887 100644 > --- a/kvm/include/linux/kvm.h > +++ b/kvm/include/linux/kvm.h > @@ -309,7 +309,7 @@ struct kvm_dirty_log { > __u32 slot; > __u32 padding1; > union { > - void __user *dirty_bitmap; /* one bit per page */ > + void *dirty_bitmap; /* one bit per page */ > __u64 padding2; > }; > }; > Huh? Doesnt that create a sparse warning? You already mention that the exported header does not contain __user and that is perfectly ok: - for the kernel dirty_bitmap is in the user address space, so we need the __user - userspace does not know and need the __user so it is removed during headers_install. Christian