From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 12/12] Kick appropriate CPUs when signalling interrupts.
Date: Wed, 2 Dec 2009 17:44:31 +0200
Message-ID: <20091202154431.GA20102@redhat.com>
References: <1259678201-11203-1-git-send-email-clalance@redhat.com>
 <1259678201-11203-13-git-send-email-clalance@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Chris Lalancette <clalance@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:29187 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752199AbZLBPo0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 2 Dec 2009 10:44:26 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB2FiXU9002355
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Wed, 2 Dec 2009 10:44:33 -0500
Content-Disposition: inline
In-Reply-To: <1259678201-11203-13-git-send-email-clalance@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Dec 01, 2009 at 03:36:41PM +0100, Chris Lalancette wrote:
> Make sure that we kick the appropriate vcpu when delivering
> an interrupt.  This makes sure that we wake any idle cpus
> to cause a "vcpu_run" and an interrupt injection to occur.
> 
> Signed-off-by: Chris Lalancette <clalance@redhat.com>
> ---
>  virt/kvm/irq_comm.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
> index 9b07734..96df854 100644
> --- a/virt/kvm/irq_comm.c
> +++ b/virt/kvm/irq_comm.c
> @@ -98,6 +98,7 @@ int kvm_irq_delivery_to_apic(struct kvm *kvm, struct kvm_lapic *src,
>  			if (r < 0)
>  				r = 0;
>  			r += kvm_apic_set_irq(vcpu, irq);
> +			kvm_vcpu_kick(vcpu);
>  		} else {
>  			if (!lowest)
>  				lowest = vcpu;
> @@ -106,8 +107,10 @@ int kvm_irq_delivery_to_apic(struct kvm *kvm, struct kvm_lapic *src,
>  		}
>  	}
>  
> -	if (lowest)
> +	if (lowest) {
>  		r = kvm_apic_set_irq(lowest, irq);
> +		kvm_vcpu_kick(lowest);
> +	}
>  
>  	return r;
>  }
kvm_vcpu_kick() is done inside kvm_apic_set_irq(), so why is this
needed?

--
			Gleb.