public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm-devel" <kvm@vger.kernel.org>
Subject: Re: Installing kernel headers in kvm-kmod
Date: Thu, 10 Dec 2009 16:25:19 +0100	[thread overview]
Message-ID: <200912101625.20134.arnd@arndb.de> (raw)
In-Reply-To: <4B210D2F.3060607@redhat.com>

On Thursday 10 December 2009, Avi Kivity wrote:
> Maybe even /usr/local/include/kvm-kmod-$version/...., and a symlink 
> /usr/local/include/kvm-kmod.

Depends on how fine-grained you want to do the packaging.
Most distributions split packages between code and development
packages. The kvm-kmod code is the kernel module, so you want
to be able to install it for multiple kernels simultaneously.

Building the package only requires one version of the header
and does not depend on the underlying kernel version, only
on the version of the module, so it's reasonable to install only
one version as the -dev package, and have a dependency
in there to match the module version with the header version.

The most complex setup would split the development package
into one per kernel version and/or module version, plus an
extra package for the module version containing only the
symlink. I wouldn't go there.

> > It may also be useful to do the equivalent of 'make headers_install'
> > from the kernel, to remove all "#ifdef __KERNEL__" sections and
> > sparse annotations from the header files, but it should also work
> > without that.
> >    
> 
> Well, qemu.git needs __user removed.

This one is taken care of by kvm_kmod in the sync script, though it
would be cleaner to only do it for the installed version of the header,
not for the one used to build kvm.ko.

	Arnd <><

  reply	other threads:[~2009-12-10 15:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10 13:07 Installing kernel headers in kvm-kmod Anthony Liguori
2009-12-10 13:12 ` Avi Kivity
2009-12-10 13:35 ` Jan Kiszka
2009-12-10 14:50   ` Arnd Bergmann
2009-12-10 15:01     ` Avi Kivity
2009-12-10 15:25       ` Arnd Bergmann [this message]
2009-12-10 16:42         ` Jan Kiszka
2009-12-10 16:44           ` Avi Kivity
2009-12-10 17:14             ` Jan Kiszka
2009-12-10 20:26               ` Arnd Bergmann
2009-12-10 20:36                 ` Avi Kivity
2009-12-10 21:44       ` Anthony Liguori
2009-12-10 15:01     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912101625.20134.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox