From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd@arndb.de>
Subject: Re: Installing kernel headers in kvm-kmod
Date: Thu, 10 Dec 2009 20:26:34 +0000
Message-ID: <200912102026.34997.arnd@arndb.de>
References: <4B20F27D.3000006@codemonkey.ws> <4B21257B.6030008@redhat.com> <4B212C80.2020802@siemens.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm-devel" <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from moutng.kundenserver.de ([212.227.17.10]:64215 "EHLO
	moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750926AbZLJU0r (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Dec 2009 15:26:47 -0500
In-Reply-To: <4B212C80.2020802@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thursday 10 December 2009 17:14:40 Jan Kiszka wrote:
> Avi Kivity wrote:
> > On 12/10/2009 06:42 PM, Jan Kiszka wrote:
> >> I've just (forced-)pushed the "simple" version with
> >> /usr/include/kvm-kmod as destination. The user headers are now stored
> >> under usr/include in the kvm-kmod sources and installed from there.
> >>    
> > 
> > It's customary to install to /usr/local, not to /usr (qemu does the same).

Right. Specifically, an install from source should go to /usr/local/include
by default, while a distro package should override the path to go to
/usr/include, which the current version easily allows.

This also means that qemu will have to look in three places now,
/usr/local/include/kvm-kmod, /usr/include/kvm-kmod and /usr/include.
Adding /usr/local/include probably doesn't hurt but should not be
necessary.

> Adjusted accordingly. Moreover, I only install the target arch's header now.

Looks good now.

	Arnd